fix(ci): align required-check manifest with current workflow job names#1724
fix(ci): align required-check manifest with current workflow job names#1724KooshaPari wants to merge 1223 commits intorouter-for-me:mainfrom
Conversation
Build Fixes: - Fix duplicate type definitions in kiro_websearch_handler.go (McpRequest, McpResponse, WebSearchResults) - Fix undefined authID and wsURL variables in codex_websockets_executor.go by naming parameters - Remove unused imports (crypto/sha256, encoding/hex) from codex_websockets_executor.go - Add missing syscall import to cmd/cliproxyctl/main.go for error handling - Remove incomplete showConfigPaths block from cmd/server/main.go (undefined functions) - Remove unused strings import from copilot/token_test.go Track 1.2 - ACP Adapter: - Implement ACP adapter to translate Claude/OpenAI protocol messages to ACP protocol - Add acp_request.go: Request translation and validation - Add acp_response.go: Response translation and formatting - Add acp_adapter.go: Main adapter logic with registry integration - Add unit tests in acp_adapter_registry_test.go Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
chore: merge ci-compile-fix-clean-single lane closeout and fixes
# Conflicts: # pkg/llmproxy/api/handlers/management/auth_files.go # pkg/llmproxy/api/handlers/management/management_extra_test.go
This comment was marked as spam.
This comment was marked as spam.
Summary of ChangesHello @KooshaPari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a significant foundational update, establishing the 'CLIProxyAPI Plus' project with a robust CI/CD pipeline, enhanced development tooling, and comprehensive management capabilities. It introduces new authentication flows for a wide array of AI providers and refines the project's structure and documentation to support this expanded functionality. The changes aim to streamline development, improve code quality, and provide a more feature-rich and maintainable platform. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request has a misleading title and description. It appears to be a large-scale addition of CI/CD infrastructure, configuration files, and scripts, rather than a small fix. The most critical issue is the inclusion of the entire .worktrees directory, which is an internal Git directory and should not be version-controlled. This directory also contains files with unresolved merge conflicts and introduces inconsistencies in binary naming (cli-proxy-api-plus, CLIProxyAPIPlus, cliproxyapi++). This PR should be rejected in its current state. The .worktrees directory must be removed from the repository, and the changes should be broken down into smaller, more focused pull requests with accurate descriptions.
| @@ -1,17 +1,20 @@ | |||
| # Binaries | |||
There was a problem hiding this comment.
The .worktrees directory is being tracked by Git, but it should be ignored. This directory is for local Git worktree management and should not be part of the repository's history. Please add .worktrees/ to this .gitignore file and remove the directory from the repository's index using git rm -r --cached .worktrees.
| <<<<<<< HEAD | ||
| ======= | ||
| - Support multiple aliases for a single upstream model in OAuth model alias configuration, preserving compatibility while allowing same upstream model name with distinct aliases. | ||
| >>>>>>> archive/pr-234-head-20260223 |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). These must be resolved before merging. However, the entire .worktrees directory should be removed from this pull request as it is an internal Git directory and should not be version-controlled.
| <<<<<<< HEAD | ||
| - task: quality:docs-phase-placeholders | ||
| ======= | ||
| >>>>>>> archive/pr-234-head-20260223 | ||
| - ./.github/scripts/release-lint.sh | ||
|
|
||
| quality:docs-open-items-parity: | ||
| desc: "Prevent stale status drift in fragmented open-items report" | ||
| cmds: | ||
| - ./.github/scripts/check-open-items-fragmented-parity.sh | ||
|
|
||
| <<<<<<< HEAD | ||
| quality:docs-phase-placeholders: | ||
| desc: "Reject unresolved placeholder-like tokens in planning reports" | ||
| cmds: | ||
| - ./.github/scripts/check-phase-doc-placeholder-tokens.sh | ||
|
|
||
| ======= | ||
| >>>>>>> archive/pr-234-head-20260223 |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers. These must be resolved. As mentioned in other comments, the entire .worktrees directory should be removed from this pull request.
|
|
||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "" # See documentation for possible values haha |
There was a problem hiding this comment.
The package-ecosystem is empty, which will cause Dependabot to fail. You must specify a valid package ecosystem, such as gomod for Go modules or github-actions for GitHub Actions. Additionally, the comment haha is unprofessional and should be removed.
- package-ecosystem: "gomod" # See documentation for possible values| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| report="${REPORT_PATH:-docs/reports/fragemented/OPEN_ITEMS_VALIDATION_2026-02-22.md}" |
There was a problem hiding this comment.
The script hardcodes a future date (2026-02-22) in the report file path. This is brittle and will likely break or become outdated. The filename should be generated dynamically or passed as an argument to make the script more robust and reusable.
6 participants
This follow-up PR fixes the required-check manifest to match current workflow names and avoid false merge blocking in required-checks guard.
Changes: