Bump toml to 1.x#30
Merged
Merged
Conversation
We were pinning toml 0.5.11 which is 3 years old 1.0.0 was released 2 months ago, and tests pass fine with the latest 1.1.2. This will allow getting `emojis` packaged in Fedora without adding yet another dependency on the old `toml` 0.5 compatibility package we're trying to deprecate. Upstream changelog: https://raw.githubusercontent.com/toml-rs/toml/refs/tags/toml-v1.1.2/crates/toml/CHANGELOG.md Signed-off-by: Michel Lind <salimma@fedoraproject.org>
Owner
|
@michel-slm I see the tests are failing because toml requires at least Rust 1.85. I think you can tweak the build to just check for the msrv. (I'm okay with not running the tests on the MSRV). diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 2a9ce60..07a91d3 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -43,7 +43,7 @@ jobs:
- uses: dtolnay/rust-toolchain@1.66
- name: Test
- run: cargo test --all-features
+ run: cargo check --all-features
generated:
runs-on: ubuntu-latest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were pinning toml 0.5.11 which is 3 years old
1.0.0 was released 2 months ago, and tests pass fine with the latest 1.1.2.
This will allow getting
emojispackaged in Fedora without adding yet another dependency on the oldtoml0.5 compatibility package we're trying to deprecate.Upstream changelog: https://raw.githubusercontent.com/toml-rs/toml/refs/tags/toml-v1.1.2/crates/toml/CHANGELOG.md