Change HAS_DBACCESS() to always return 1. - #1
Open
rossd-bitquill wants to merge 4 commits into
Open
Conversation
The existing implementation of HAS_DBACCESS() would always return NULL due to an exception thrown by the underlying psql call because the Babelfish table names do not match the postgres table names. This commit changes HAS_DBACCESS to always return 1. The underlying issue will be fixed alongside a larger implementation of permissions/ownership. Signed-off-by: rossd-bitquill <rossd@bitquilltech.com>
Signed-off-by: rossd-bitquill <rossd@bitquilltech.com>
Signed-off-by: rossd-bitquill <rossd@bitquilltech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing HAS_DBACCESS() implementation always returned NULL due to an exception thrown by the Psql call, because the Babelfish table names do not agree with the Postgres table names.
This is a temporary change to the HAS_DBACCESS() procedure to always return 1. Expected functionality will be implemented along with a larger piece of work to implement the permissions/ownership of tables and databases in Babelfish.
Issues Resolved
None
Check List
[ X ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.