Scicat instrument preferences #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abigailalexander
changed the title
|
This pull request introduces 1 alert when merging 207a844 into fb26615 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4360a5e into fb26615 - view on LGTM.com new alerts:
|
Contributor
Author
|
Looks like the tests were failing before because the ci couldn't locate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds in instrument dictionary functionality. It looks for an
instrument-prefs.ymlfile inside a specifiedinstrument-configdirectory (this probably isn't the best way of doing this, so subject to change). If no file is provided, it loads a default instrument prefs file from that directory to create the instrument setup entrypoint. This is then used to populate the techniques dropdown. Also prevents users from sending payload to scicat if no instrument is specified other than the default one.