Skip to content

Added tampered buffer deserialization tests #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Added tampered buffer deserialization tests #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d8aaf3
Added tampered buffer deserialization tests
MiguelCompany Feb 3, 2021
a220591
Keep linters happy.
MiguelCompany Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions test_rmw_implementation/test/test_serialize_deserialize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include "test_msgs/msg/basic_types.h"
#include "test_msgs/msg/basic_types.hpp"
#include "test_msgs/msg/unbounded_sequences.h"
#include "test_msgs/msg/unbounded_sequences.hpp"

#include "./allocator_testing_utils.h"

Expand Down Expand Up @@ -141,6 +143,57 @@ TEST_F(CLASSNAME(TestSerializeDeserialize, RMW_IMPLEMENTATION), clean_round_trip
rmw_get_error_string().str;
}

TEST_F(CLASSNAME(TestSerializeDeserialize, RMW_IMPLEMENTATION), tampered_buffer_for_c_message) {
const rosidl_message_type_support_t * ts{
ROSIDL_GET_MSG_TYPE_SUPPORT(test_msgs, msg, UnboundedSequences)};
test_msgs__msg__UnboundedSequences message{};
ASSERT_TRUE(test_msgs__msg__UnboundedSequences__init(&message));
rcutils_allocator_t default_allocator = rcutils_get_default_allocator();
rmw_serialized_message_t serialized_message = rmw_get_zero_initialized_serialized_message();
ASSERT_EQ(
RMW_RET_OK, rmw_serialized_message_init(
&serialized_message, 0lu, &default_allocator)) << rmw_get_error_string().str;

rmw_ret_t ret = rmw_serialize(&message, ts, &serialized_message);
EXPECT_EQ(RMW_RET_OK, ret) << rmw_get_error_string().str;
EXPECT_NE(nullptr, serialized_message.buffer);
EXPECT_GT(serialized_message.buffer_length, 0lu);

// Tamper the serialized message to force deserialization failure
memset(serialized_message.buffer, 0xFF, serialized_message.buffer_length);

ret = rmw_deserialize(&serialized_message, ts, &message);
EXPECT_NE(RMW_RET_OK, ret) << rmw_get_error_string().str;

EXPECT_EQ(RMW_RET_OK, rmw_serialized_message_fini(&serialized_message)) <<
rmw_get_error_string().str;
}

TEST_F(CLASSNAME(TestSerializeDeserialize, RMW_IMPLEMENTATION), tampered_buffer_for_cpp_message) {
const rosidl_message_type_support_t * ts =
rosidl_typesupport_cpp::get_message_type_support_handle<test_msgs::msg::UnboundedSequences>();
test_msgs::msg::UnboundedSequences message{};
rcutils_allocator_t default_allocator = rcutils_get_default_allocator();
rmw_serialized_message_t serialized_message = rmw_get_zero_initialized_serialized_message();
ASSERT_EQ(
RMW_RET_OK, rmw_serialized_message_init(
&serialized_message, 0lu, &default_allocator)) << rmw_get_error_string().str;

rmw_ret_t ret = rmw_serialize(&message, ts, &serialized_message);
EXPECT_EQ(RMW_RET_OK, ret) << rmw_get_error_string().str;
EXPECT_NE(nullptr, serialized_message.buffer);
EXPECT_GT(serialized_message.buffer_length, 0lu);

// Tamper the serialized message to force deserialization failure
memset(serialized_message.buffer, 0xFF, serialized_message.buffer_length);

ret = rmw_deserialize(&serialized_message, ts, &message);
EXPECT_NE(RMW_RET_OK, ret) << rmw_get_error_string().str;

EXPECT_EQ(RMW_RET_OK, rmw_serialized_message_fini(&serialized_message)) <<
rmw_get_error_string().str;
}

TEST_F(CLASSNAME(TestSerializeDeserialize, RMW_IMPLEMENTATION), rmw_get_serialized_message_size)
{
if (rmw_get_serialized_message_size(nullptr, nullptr, nullptr) != RMW_RET_UNSUPPORTED) {
Expand Down