-
Couldn't load subscription status.
- Fork 37
Add XML files to describe built-in QoS configuration #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asorbini
wants to merge
15
commits into
rolling
Choose a base branch
from
asorbini/xml-qos-profiles
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7830c78 to
e3c787f
Compare
1dea8e7 to
08eddf3
Compare
|
I have updated and extended the README quite a bit:
|
62a3d16 to
fda315a
Compare
Signed-off-by: Andrea Sorbini <[email protected]>
…_QOS_PROFILES Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
…he RMW Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
Signed-off-by: Andrea Sorbini <[email protected]>
fda315a to
234c89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
foxy-backports
PR should be backported to Foxy
galactic-backports
PR should be backported to Galactic.
humble
PR scheduled for the H-turtle
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some example XML QoS profiles that users can derive from in their own configuration files to replicate the settings applied by default by
rmw_connextdds.These profiles will help applications to remain compatible with other applications when
ENDPOINT_QOS_OVERRIDE_POLICYis set tonever(orPARTICIPANT_QOS_OVERRIDE_POLICY, when/if #41 is merged).The profiles are all stored in file
rmw_connextdds/resource/xml/ros2_qos_profiles.xml, which contains the following profiles:ros2::rmw.ros_discovery_inforos2::rcl.node_parametersros2::rcl.logros2::rcl.builtin_endpointsros2::rmw_connextdds.base_participantros2::rmw_connextdds.base_applicationros2::rmw_connextdds.opt.large_dataros2::rmw_connextdds.opt.unbounded_dataros2::rmw_connextdds.opt.content_filtered_topic_propertyros2::rmw_connextdds.opt.localhost_onlyros2::rmw_connextdds.opt.fast_endpoint_discoveryRefer to the comments in the file for details about each profile.
Users should have their profiles include
ros2::rmw_connextdds.base_applicationin their parent hierarchy to replicate the configuration used byrmw_connextddsout of the box, and use profilesros2::rmw_connextdds.opt.*to introduce additional configurations that the RMW only applies optionally.An example file (
USER_QOS_PROFILES.example.xml) provides a template for what users should place in an application's runtime directory. The file contains a single profile which inherits fromros2::rmw_connextdds.base_applicationand adds rules to configure the QoS of topic "rt/chatter".File
ros2_qos_profiles.xmlis now exported byrmw_connextddsand a new environment hook (only for non-Windows users at the moment) will automatically append it toNDDS_QOS_PROFILES, so that the profiles will be available to users without any further configuration.For example, to use the profiles with the hello world examples and verify that they are compatible with the default settings, after building
rmw_connextdds: