remove I/O from signal handler. #3000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
force-pushed
the
fujitatomoya/pull/2986/kilted/backport
branch
from
58c4c40 to
fecd6f5
Compare
Collaborator
Author
|
@jmachowinski do we have other options to backport #2986? i tried to think of the possible approach, but ended up having this PR instead. |
Collaborator
Author
|
Pulls: #3000, ros2/system_tests#580
|
Collaborator
Author
|
@jmachowinski friendly ping |
jmachowinski
requested changes
Dec 2, 2025
Collaborator
Author
|
No worries, thanks for coming back 👍 Ah yeah that is what i though too, that we can do at least. i will add it and start the CI. |
Signed-off-by: Tomoya Fujita <[email protected]>
Collaborator
Author
|
jmachowinski
approved these changes
Dec 3, 2025
Collaborator
Author
|
ahcorde
approved these changes
Dec 4, 2025
Collaborator
Author
|
@Mergifyio backport jazzy humble |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 3ce946f)
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 3ce946f)
This was referenced Dec 4, 2025
ahcorde
pushed a commit
that referenced
this pull request
Dec 5, 2025
(cherry picked from commit 3ce946f) Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Dec 8, 2025
(cherry picked from commit 3ce946f) Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2986
I tried to think of the ABI compatible way to backport the #2986, because it is critical issue.
But ended up removing the I/O (including possible rcl_publish) from the signal handler.
signal_received_asstd::atomic_intto store the signal number. this also changes the memory layout/alighment from 1 byte to 4 bytes. checked with amd64 and arm64 platform, this is also gonna be the breaking ABI change, and not guaranteed by standard.Note
this requires ros2/system_tests#580
Is this user-facing behavior change?
Yes, the user application cannot expect the logging message (or publish) via signal handler.
Did you use Generative AI?
No,
Additional Information