Skip to content

throws std::invalid_argument if ParameterEvent is NULL. #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fujitatomoya merged 1 commit into from
Apr 24, 2025
Merged

throws std::invalid_argument if ParameterEvent is NULL. #2814

fujitatomoya merged 1 commit into from
Apr 24, 2025

Conversation

@fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Apr 14, 2025

closes #2810

@fujitatomoya
throws std::invalid_argument if ParameterEvent is NULL.
472eeed 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Apr 14, 2025
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcarroll can you review and merge?

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Apr 14, 2025 •
edited by ahcorde
Loading

Pulls: #2814
Gist: https://gist.githubusercontent.com/fujitatomoya/2a767b5e60c8edf018835c6331758022/raw/94732926775ffb309aa0430af22451af7ee6d014/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15684

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Apr 14, 2025
Closed
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Apr 22, 2025

Warning

DO NOT MERGE THIS, WE ARE NOW BRANCHING KILTED.

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Apr 24, 2025

warnings are unrelated and known issues.

@fujitatomoya fujitatomoya merged commit 8b9691f into rolling Apr 24, 2025
2 of 3 checks passed
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Apr 24, 2025

@Mergifyio backport humble jazzy

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2025 •
edited
Loading

backport humble jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 24, 2025
@fujitatomoya @mergify
throws std::invalid_argument if ParameterEvent is NULL. (#2814)
4d7837b 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8b9691f)
mergify bot pushed a commit that referenced this pull request Apr 24, 2025
@fujitatomoya @mergify
throws std::invalid_argument if ParameterEvent is NULL. (#2814)
b35713c 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8b9691f)
This was referenced Apr 24, 2025
Merged
Merged
fujitatomoya added a commit that referenced this pull request May 1, 2025
@mergify @fujitatomoya
throws std::invalid_argument if ParameterEvent is NULL. (#2814) (#2824)
b6cd839 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8b9691f)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request May 5, 2025
@mergify @fujitatomoya
throws std::invalid_argument if ParameterEvent is NULL. (#2814) (#2825)
8266f85 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8b9691f)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloretz sloretz sloretz approved these changes

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash due to Unhandled Null Pointer in ParameterEventsFilter Constructor

4 participants

@fujitatomoya @sloretz @jmachowinski