Add function to call through to dds layer to notify about new network interfaces #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Jakymiw <[email protected]>
jakymiws
force-pushed
the
irobot/add-dynamic-interface-network-notify
branch
from
7a217a5 to
440756f
Compare
This was referenced Jan 19, 2023
alsora
reviewed
Jan 19, 2023
rclcpp/include/rclcpp/utilities.hpp
Outdated
| std::vector<const char *> | ||
| get_c_vector_string(const std::vector<std::string> & strings_in); | ||
|
|
||
| /// Call dds to notify about new network interfaces. |
There was a problem hiding this comment.
This layer shouldn't assume that the underlying middleware is a DDS.
Maybe the comment should say something like "Notify middleware to refresh available network interfaces?"
There was a problem hiding this comment.
@alsora good point - will change that.
|
@jakymiws we should also add a function implementation in the other TIER 1 RMW middelwares. |
Signed-off-by: Sebastian Jakymiw <[email protected]>
This was referenced Jan 23, 2023
|
@alsora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly related to
irobot/add-dynamic-network-notify-functioninjakymiws/rcl