Repository navigation
feat: add Level 1-4 examples, 27 docs, and full CI coverage - #1
Merged
Merged
Conversation
- Add 20 new demo packages (Level 1-3 from previous round + Level 4) - Level 4 "Debugging & Performance": demo_xmake_logging, demo_xmake_tracing, demo_xmake_benchmark - Add 27 tutorial docs with "内容扩展" sections (curated links to projects/tools/papers) - Update CI: build all packages, install extra ROS deps (tf2, cv_bridge, nav2, ros2_control, etc.) - Update runtime_smoke.sh with tests for all new packages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cv_bridge in ROS 2 Jazzy uses .hpp extension instead of .h Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cv_bridge depends on OpenCV but add_ros_deps doesn't transitively propagate system library include paths. Add explicit opencv package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
add_ros_deps("cv_bridge") doesn't transitively resolve OpenCV headers
and linking. Use add_cxflags + add_links for explicit opencv support.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Root cause: add_ros_deps resolves cv_bridge via add_ldflags (full path),
but xmake places add_packages (-l flags) before add_ldflags in the link
command. This causes the linker to not see cv_bridge.so when resolving
symbols from the object files.
Fix: use add_requires("opencv", {system = true}) for OpenCV, and
add_links("cv_bridge") to ensure cv_bridge is linked via -l flag
at the same priority level as opencv libraries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
With colcon-xmake now parsing export_targets and ament_xmake using
add_links instead of add_ldflags, the explicit add_links("cv_bridge")
workaround is no longer needed.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
demo_xmake_service requires example_interfaces which is not included in the base ros:jazzy container image. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
E2E Build & Testworkflow passes (builds all 26 packages)🤖 Generated with Claude Code