Skip to content

Conversation

@Rezenders
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on None
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

Shouldn't the from_ll_to_map_client_ service client have a relative name fromLL instead of a global name /fromLL to match the from_ll_srv_ service server name defined in the navsat_transform_node from robot_localization?

from_ll_to_map_client_ = node->create_client<robot_localization::srv::FromLL>(
"/fromLL",
true /*creates and spins an internal executor*/);

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.


from_ll_to_map_client_ = node->create_client<robot_localization::srv::FromLL>(
"/fromLL",
"fromLL",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this is that then the service will be placed under a namespace that the waypoint follower node is placed in -- not the namespace that potentially the robot localization node is. I think this may be better to be remapped in your launch file from /fromLL -> /my_rl_ns/fromLL that way you explicitly control what namespace this is applied to. There's no reason to expect that the namespace of the WPF will be the same as RL - especially if you consider that many GPS applications may have 2 or 3 RL instances that could either be named uniquely or namespaced uniquely - separate of the application namespace itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants