Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ispathvalid maxcost #4873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mini-1235
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4756
Primary OS tested on Ubuntu 24.04
Robotic platform tested on Custom simulation environment
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Add max cost as described in the issue
  • Add corresponding test

Description of documentation updates required from your changes

Add new parameter description https://docs.nav2.org/configuration/packages/bt-plugins/conditions/IsPathValid.html

Description of how this change was tested

Wrote a new test to test this and also tested on custom simulation env


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: mini-1235 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant