-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update padFootprint() function #4832
base: main
Are you sure you want to change the base?
update padFootprint() function #4832
Conversation
@Nisarg236, your PR has failed to build. Please check CI outputs and resolve issues. |
@Nisarg236, your PR has failed to build. Please check CI outputs and resolve issues. |
Please fix build, linting, and DCO issues before we give this a review :-) |
// pad footprint in place | ||
for (unsigned int i = 0; i < footprint.size(); i++) { | ||
geometry_msgs::msg::Point & pt = footprint[i]; | ||
pt.x += sign0(pt.x) * padding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point out to me the error in the code here - I don't see any immediately.
Is the issue the case where you have a coordinate exactly at 0.0
? 0.0
for the footprint would be the center of your robot, since that is the 0.0, 0.0
w.r.t. your base_link or base_footprint frame -- which is almost always the center of your robot or aligned with some axle that wouldn't then be a corner of a robot. That would point to me more an issue in your configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nisarg236 should this be closed?
Basic Info
Description of contribution in a few bullet points
Case 1: (0,0), (0,2), (2,2), (2,0)
Case 2: (10,10), (10,12), (12,12) , (12,10)
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: