update docs for iterative graceful controller #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
|
TODO (after review and updates to underlying PR):
|
Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
SteveMacenski
approved these changes
Dec 17, 2024
Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
There was a problem hiding this comment.
@mikeferguson a few additions:
- You changed the defaults of the k/beta parameters, the new defaults should be updated in this table
- In the migration guide, we should mention this (Pretty big) change
- In the Navigation Plugins table, I'd add in omni as supported motion models (not just diff)
Where in the migration doc do we want this? The Jazzy->K-turtle part, or are we planning to backport at all? |
Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
|
Since it changes and removes parameters, it cannot be backported, so J->K |
Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
|
@SteveMacenski - added requested items - I think this ready for a final review |
SteveMacenski
approved these changes
Dec 20, 2024
john-chrosniak
pushed a commit
to usdot-fhwa-stol/docs.nav2.org
that referenced
this pull request
Jan 14, 2025
* update docs for iterative graceful controller Signed-off-by: Michael Ferguson <[email protected]> * add add_orientations Signed-off-by: Michael Ferguson <[email protected]> * updates after review comments Signed-off-by: Michael Ferguson <[email protected]> * additional review udpates Signed-off-by: Michael Ferguson <[email protected]> * update notes on initial rotation tolerance Signed-off-by: Michael Ferguson <[email protected]> * trailing whitespace Signed-off-by: Michael Ferguson <[email protected]> * update defaults for control law Signed-off-by: Michael Ferguson <[email protected]> * add omni, legged Signed-off-by: Michael Ferguson <[email protected]> * update migration docs Signed-off-by: Michael Ferguson <[email protected]> * spelling/linter Signed-off-by: Michael Ferguson <[email protected]> --------- Signed-off-by: Michael Ferguson <[email protected]> Signed-off-by: John Chrosniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc changes for ros-navigation/navigation2#4795