Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document bt_navigator error_code_name_prefixes and error_msg #587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aosmw
Copy link

@aosmw aosmw commented Aug 31, 2024

Documents featured added to support returning Error codes and messages from failed NavigateToPose/NavigateThroughPoses actions ros-navigation/navigation2#4341

@aosmw aosmw marked this pull request as draft August 31, 2024 10:17
Signed-off-by: Mike Wake <[email protected]>
@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch from 47c9846 to 61cc31a Compare August 31, 2024 10:19
@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch from 795dcae to 23e4b92 Compare August 31, 2024 10:28
@aosmw aosmw marked this pull request as ready for review August 31, 2024 10:53
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM

migration/Jazzy.rst Outdated Show resolved Hide resolved
migration/Jazzy.rst Outdated Show resolved Hide resolved
@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch from 8d20961 to ed98c63 Compare September 7, 2024 02:31
Signed-off-by: Steve Macenski <[email protected]>

A new parameter for the BT Navigator "error_code_name_prefixes" was introduced. It replaces the "error_code_id_names" parameter to support both an error code and an associated error message. Behavior tree elements that support an "error_code_id" and "error_msg" attribute, must have values that use the corresponding prefix with the suffix "_error_code" and "_error_msg" respectively. The error messages can then be viewed by applications calling Nav2 or its servers for handling specific errors with more contextual information than simply the error code.

Thus, users must update their ``nav2_params.yaml`` to include this new format of specifying error message and code locations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the example replacement YAML to:

    error_code_name_prefixes:
      - compute_path
      - follow_path

from

    error_code_names:
      - compute_path_error_code
      - follow_path_error_code

To be clear to users what this means, this is a pretty key 'mess up' alot of people will make without very clear instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants