Skip to content

Conversation

peakyquest
Copy link

@peakyquest peakyquest commented Sep 24, 2025

I put together the UML class diagram and tried to keep it simple. I also added a notes section that connects it with example_1, so users can better follow what each block represents. I also made the flow diagram in draw.io and added the .svg file in the doc folder. Additionally, I’m including the .png format below for easier viewing.

class

After review and finalization, I plan to work on documentation that explains each process in detail. Please let me know whether these files should be kept inside the doc folder or placed within the example_1 directory.

@peakyquest
Copy link
Author

I have added a README file to the example_1 directory.
Please review the changes and advise if any modifications are required either in the UML diagram or in the README content.

@christophfroehlich
Copy link
Contributor

I have added a README file to the example_1 directory. Please review the changes and advise if any modifications are required either in the UML diagram or in the README content.

Please don't, we use the doc/index.rst to be published on control.ros.org
And please remove all the LLM icon decorations in the text.

@peakyquest
Copy link
Author

peakyquest commented Sep 29, 2025

Do you want me to delete the README file from the doc folder and move its content into doc/index.rst? I’ll also remove the references to LLM icons from the text.

@peakyquest
Copy link
Author

About the UML diagram, do I need to make changes on that as well?

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Sep 29, 2025

Do you want me to delete the README file from the doc folder and move its content into doc/index.rst? I’ll also remove the references to LLM icons from the text.

just leave the README as it is, it it just a summary and points to the rst file.

@peakyquest
Copy link
Author

peakyquest commented Sep 30, 2025

I’ve removed the icons and pointed the summary in the userdocs.rst. I hope this is what you were asking for, I apologizes as I am still learning

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to include the text (formatted as RSt) in userdoc.rst, to have it automatically published https://control.ros.org/rolling/doc/ros2_control_demos/example_1/doc/userdoc.html
The syntax is a bit different, you can iterate with the github UI preview or install sphinx and build it locally, see https://github.com/ros-controls/control.ros.org/?tab=readme-ov-file#build-instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants