Skip to content

Revert spawner reordering#547

Merged
christophfroehlich merged 5 commits intomasterfrom
revert_spawner_reordering
Nov 17, 2025
Merged

Revert spawner reordering#547
christophfroehlich merged 5 commits intomasterfrom
revert_spawner_reordering

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich commented Jul 29, 2024

Follow-up to #540.

Re-evalute if there is a fix for ros2/rclpy#1320

@christophfroehlich christophfroehlich changed the base branch from master to add_launch_tests July 29, 2024 13:09
Base automatically changed from add_launch_tests to master July 30, 2024 07:14
@christophfroehlich christophfroehlich force-pushed the revert_spawner_reordering branch from 19402fb to a1fde13 Compare July 30, 2024 07:43
@ros-controls ros-controls deleted a comment from mergify Bot Jul 30, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 29, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 2, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Jul 2, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 2, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions Bot removed the stale label Jul 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Aug 18, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Aug 18, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions Bot removed the stale label Aug 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 6, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Oct 6, 2025
@christophfroehlich christophfroehlich mentioned this pull request Nov 14, 2025
Closed
@christophfroehlich christophfroehlich marked this pull request as ready for review November 14, 2025 09:04
@christophfroehlich christophfroehlich moved this to Needs review in Review triage Nov 14, 2025
@christophfroehlich
Copy link
Copy Markdown
Member Author

christophfroehlich commented Nov 14, 2025 •
edited
Loading

Now the tests passes, unsure if the linked issue got fixed or it is just seldomly flaky.

@github-actions github-actions Bot removed the stale label Nov 14, 2025
@christophfroehlich christophfroehlich merged commit a265305 into master Nov 17, 2025
11 checks passed
@christophfroehlich christophfroehlich deleted the revert_spawner_reordering branch November 17, 2025 21:08
@github-project-automation github-project-automation Bot moved this from Needs review to Done in Review triage Nov 17, 2025
@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-humble Triggers PR backport to ROS 2 humble. labels Nov 17, 2025
mergify Bot pushed a commit that referenced this pull request Nov 17, 2025
@christophfroehlich @mergify
Revert spawner reordering (#547)
296bced 
(cherry picked from commit a265305)

# Conflicts:
#	example_11/bringup/launch/carlikebot.launch.py
mergify Bot pushed a commit that referenced this pull request Nov 17, 2025
@christophfroehlich @mergify
Revert spawner reordering (#547)
8817ae6 
(cherry picked from commit a265305)
This was referenced Nov 17, 2025
Merged
Merged
christophfroehlich pushed a commit that referenced this pull request Nov 17, 2025
@mergify
Revert spawner reordering (backport #547) (#966)
5df05df
christophfroehlich added a commit that referenced this pull request Nov 17, 2025
@mergify @christophfroehlich
Revert spawner reordering (#547) (#967)
0a6832a 
(cherry picked from commit a265305)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikishor saikishor saikishor approved these changes

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@harderthan harderthan Awaiting requested review from harderthan

@mhubii mhubii Awaiting requested review from mhubii

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees

No one assigned

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

Review triage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christophfroehlich @saikishor