-
Notifications
You must be signed in to change notification settings - Fork 390
Fix the blocking calls of lifecycle_state in the real-time loop (backport #2884) #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit dca9b57) # Conflicts: # doc/release_notes.rst
|
Cherry-pick of dca9b57 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jazzy #2890 +/- ##
==========================================
- Coverage 89.30% 89.25% -0.05%
==========================================
Files 155 155
Lines 18059 18125 +66
Branches 1468 1473 +5
==========================================
+ Hits 16127 16177 +50
- Misses 1352 1366 +14
- Partials 580 582 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Merging despite the ABI break, because this fixes a serious performance issue. |
Hello!
I've observed a lot of blocking time of the RT loop due to the calls of the lifecycle state and this PR comes up with a way to cache them locally and use them.
With the current master's version:
RRBot


TALOS
With the proposed changes:
RRBot

TALOS

This is an automatic backport of pull request #2884 done by [Mergify](https://mergify.com).