Fix warnings of uninitialized registry in GenericSystem tests #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
livanov93,
mamueluth,
moriarty and
progtologist
saikishor
approved these changes
Oct 8, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit 096da1a) # Conflicts: # hardware_interface/test/mock_components/test_generic_system.cpp
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit 096da1a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit 096da1a)
Yes, but for example in |
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 8, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 556 lines of warnings in the test log:
2025-10-07T19:47:17.0507820Z 9: [WARN] [1759866436.596361910] [pal_statistics]: Unable to register entity state_interface.joint1/position in ros2_control, as the registry is not found. Try initializing it!There are hundreds more, I just haven't understood why it does not find the registry.