Skip to content

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Oct 7, 2025

Earlier we were using the objects directly instead of the pointers, and that means inorder for the controllers to have access the onyl way is to store the reference to that particular variable

However, In the new approach with the pointers, we cannot have the reference to the internal memory of the pointers, it is dangerous as in previous case that the loaned interfaces have access to data without having the ownership, this means if everyone removes this interface, we will have a dangling interface

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Oct 7, 2025
@saikishor saikishor removed the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Oct 7, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the explanation why we should change this.

I was just wondering if we should check the use_count when accessing the handle (if there exists even a hardware with it), but I don't know if this is an expensive operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-kilted Triggers PR backport to ROS 2 kilted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants