Skip to content

[CM] Set default strictness of switch_controllers using parameters #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

As the title suggests, the idea is to be able to use the set the default behavior of the strictness of the switch_controllers service

@saikishor saikishor changed the title [CM] Set default stictness of switch_controllers using parameters [CM] Set default strictness of switch_controllers using parameters Apr 7, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is reasonable, LGTM. Just one minor thing: release notes pls ;)

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (7d81236) to head (84c631a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2168   +/-   ##
=======================================
  Coverage   89.12%   89.13%           
=======================================
  Files         139      139           
  Lines       16117    16122    +5     
  Branches     1389     1388    -1     
=======================================
+ Hits        14364    14370    +6     
+ Misses       1224     1223    -1     
  Partials      529      529           
Flag Coverage Δ
unittests 89.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 82.53% <100.00%> (+0.98%) ⬆️
controller_manager/controller_manager/spawner.py 74.82% <100.00%> (+0.36%) ⬆️
controller_manager/controller_manager/unspawner.py 70.73% <100.00%> (+1.50%) ⬆️
controller_manager/src/controller_manager.cpp 76.25% <100.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants