Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checks on macOS #89

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Fix checks on macOS #89

merged 6 commits into from
Feb 4, 2025

Conversation

stitam
Copy link
Collaborator

@stitam stitam commented Feb 3, 2025 •
edited
Loading

Related to #88.

Checks fail on macOS. The error message suggests the issue has to do with memory limitation. My understanding is that for some reason R is holding on to the requested memory and not giving it back to the OS. With this PR I am trying to resolve this by explicitly calling gc() to give memory back to the OS.

@stitam
Copy link
Collaborator Author

stitam commented Feb 4, 2025 •
edited
Loading

vroom::vroom() seems to be a good alternative to readr::read_tsv_chunked(). I'm going to work on this a bit more and then merge the PR. vroom benchmarks: https://cran.r-project.org/web/packages/vroom/vignettes/benchmarks.html

@stitam stitam marked this pull request as draft February 4, 2025 07:34
@stitam stitam marked this pull request as ready for review February 4, 2025 20:53
@stitam stitam merged commit 83488da into ropensci:master Feb 4, 2025
5 checks passed
@stitam stitam deleted the gbif branch February 4, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stitam