Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lines to detect user's ip, if the ip is in China, use the mirror site #299

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

guohuansu
Copy link
Contributor

Description

I add a few lines in the fb_tbl function to tedect the location of the user's ip address. If the ip is in China, it will refer to the mirror site of huggingface website.

Related Issue

issue#291

change to mirror site for users in China
Add httr package
@cboettig
Copy link
Member

Thanks much @guohuansu ! Can you also please add yourself as a contributor (ctb) in the DESCRIPTION, bump the version to 5.0.1, and add a note in NEWS regarding this fix?

Much appreciated!

@cboettig
Copy link
Member

Looks great and the checks are all happy. 🚀 🐟 thanks!

@cboettig cboettig merged commit ed14218 into ropensci:master Nov 21, 2024
5 checks passed
@guohuansu
Copy link
Contributor Author

Looks great and the checks are all happy. 🚀 🐟 thanks!

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants