You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That's the bandaid fix, yes. But these tests are there for a reason, namely to check that the ungraceful behavior of dplyr::coalesce remains present as the raison d'être for coalesce()_.
I've been away for a week, so haven't had time to investigate yet. The issue should not be closed until we have investigated and decided that coalesce_() remains needed.
Right. I believe these two checks are actually checking the behavior of
dplyr and not our package? And it looks like the most recent dplyr does not
have this ungraceful behavior?
On Wed, Jun 10, 2020 at 12:30 PM Hilmar Lapp ***@***.***> wrote:
That's the bandaid fix, yes. But these tests are there for a reason,
namely to check that the ungraceful behavior of dplyr::coalesce remains
present as the raison d'être for coalesce()_.
I've been away for a week, so haven't had time to investigate yet. The
issue should not be closed until we have investigated and decided that
coalesce_() remains needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<f98ebc9#commitcomment-39815994>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABWK6UHFR3R3OVXQ6DDHGLRV7NLXANCNFSM4N2S3QLA>
.
2 commit comments
hlapp commentedon Jun 10, 2020
That's the bandaid fix, yes. But these tests are there for a reason, namely to check that the ungraceful behavior of
dplyr::coalesce
remains present as the raison d'être forcoalesce()_
.I've been away for a week, so haven't had time to investigate yet. The issue should not be closed until we have investigated and decided that
coalesce_()
remains needed.cboettig commentedon Jun 10, 2020