Allow setting a custom instance name in Lima #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalepgrant
force-pushed
the
feature/vm-instance-name
branch
from
70054fd to
47fa754
Compare
dalepgrant
changed the title
|
Thanks for the pull request @dalepgrant . Hope @swalkinshaw can have a look see one of these days. Would really help getting macOS VMs to work with multiple sites on one virtual machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #514
A WIP but I've run out of time today, hopefully will pick this back up this week. Pushing up as I'm not even sure this is the right approach or wanted functionality, any feedback welcomed.Edit: Have been using this locally for a couple of weeks, haven't hit any issues. Opening this up for review & approval after a nudge in Discourse from @jasperf.