Don't leak env values into $_SERVER
#598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
dont-load-env-values-into-server-superglobal
branch
from
4bf21d7 to
c68c908
Compare
swalkinshaw
commented
May 29, 2021
config/application.php
Outdated
| $dotenv = Dotenv\Dotenv::createUnsafeImmutable($root_dir, ['.env', '.env.local'], false); | ||
| $repository = Dotenv\Repository\RepositoryBuilder::createWithNoAdapters() | ||
| ->addAdapter(Dotenv\Repository\Adapter\EnvConstAdapter::class) | ||
| ->addAdapter(Dotenv\Repository\Adapter\PutenvAdapter::class) |
There was a problem hiding this comment.
@QWp6t needed this as well to mirror the default behaviour and get everything working
4 tasks
|
Is this still necessary to fix #474? |
|
@montchr I think so! Thanks for the bump, I think this just got forgotten about 😅 will get this rebased and hopefully reviewed soon cc @QWp6t @tangrufus |
Given that this package doesn't have an upgrade path because it's a boilerplate, I wouldn't worry about breaking changes |
|
merge? |
retlehs
force-pushed
the
dont-load-env-values-into-server-superglobal
branch
from
c68c908 to
e24bb46
Compare
retlehs
changed the title
$_SERVER
Updates to using a custom repository for `Dotenv` instead of the default which includes `ServerConstAdapter`. The new custom repository *only* includes `EnvConstAdapter`. The `$_SERVER` superglobal often gets dumped into logs or into monitoring services so it's better for security to avoid populating it with secrets contained in `.env`. Co-authored-by: Ben Word <[email protected]>
retlehs
force-pushed
the
dont-load-env-values-into-server-superglobal
branch
from
e24bb46 to
4f77694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to using a custom repository for
Dotenvinstead of the default which includesServerConstAdapter.The new custom repository only includes
EnvConstAdapter.The
$_SERVERsuperglobal often gets dumped into logs or into monitoring services so it's better for security to avoid populating it with secrets contained in.env.Note: this could be a breaking change for some users, but we at least need to ensure it's not breaking in the normal case.
Close #474