-
-
Notifications
You must be signed in to change notification settings - Fork 2
Feat: Add script to replace keyword placeholders with user input #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix: config file name not changing Opt: remove unused variables Fix: author_email not changing in composer.json Fix: composer package name placeholder use correct variable Fix: don't run composer test script because it does not exist
I'd like to get rid of all the curl/endpoint stuff as well as any over the top "automation" where possible. The Filament team's take in their plugin skeleton might be a good place to draw some inspiration on simplifying things: https://github.com/filamentphp/plugin-skeleton/blob/main/configure.php |
Thanks for the comments @Log1x 🙇♂️. The code styling in composer.json is corrected, and I've simplified the configure.php. Let me know what you think now. |
Was playing with a script setup for replacing base example package details , but it seems this Laravel / Filament kind of way is much better. Hope we get this merged soon. Did a test running
so
would be better when it would have been three words. Furthermore I had to make some tweaks:
But beyond that I do not see issues yet. But will have to test some more. Here the script for reference: https://gist.github.com/jasperf/7fb70fd696d39666475581f62cf7cc43 |
This PR adds a PHP script that automates the process of replacing the dummy Class Names, Namespaces, File names and etc, with real user entered data.