Fix CMake configuration and build with oneTBB

[hahnjo]

Versions newer than 2021 don't have the header tbb/tbb_config.h,
see cms-sw/cmsdist#6936

[phsft-bot]

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressIOPlugins_xroot
• projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_treeprocessormt_remotefiles

[phsft-bot]

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.runtutorials.tutorial_dataframe_df101_h1Analysis
• projectroot.runtutorials.tutorial_dataframe_df033_Describe_py
• projectroot.runtutorials.tutorial_dataframe_df102_NanoAODDimuonAnalysis
• projectroot.runtutorials.tutorial_dataframe_df103_NanoAODHiggsAnalysis
• projectroot.runtutorials.tutorial_dataframe_df102_NanoAODDimuonAnalysis_py
• projectroot.runtutorials.tutorial_dataframe_df103_NanoAODHiggsAnalysis_py
• projectroot.test.test_stressIOPlugins_xroot
• projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_treeprocessormt_remotefiles

[mrodozov]

now with that config it tries to compile two files from the prev commit which are including tbb/tbb_config.h
-> fails with file not found:

-c /build/mrodozov/root/build_root_master/BUILD/slc7_amd64_gcc900/lcg/root/6.25.0\
1/root-6.25.01/core/imt/src/TThreadExecutor.cxx                                                                                                                                    
/build/mrodozov/root/build_root_master/BUILD/slc7_amd64_gcc900/lcg/root/6.25.01/root-6.25.01/core/imt/src/TThreadExecutor.cxx:3:10: fatal error: tbb/tbb_config.h: No such file or\
 directory                                                                                                                                                                         
    3 | #include "tbb/tbb_config.h"  

maybe wrap them in a macro version check or something (not sure if TBB defines version through macroses)

[hahnjo]

now with that config it tries to compile two files from the prev commit which are including tbb/tbb_config.h

That is what happens if I only test CMake configuration, but not the build itself. I'm working on a proper fix, hopefully I can find a header that can be included in all versions of TBB (otherwise we have a chicken-and-egg problem which header to include for finding out the version...)

[phsft-bot]

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora32/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

[hahnjo]

We don't need the include of tbb_config.h at all, the other headers will pull the configuration in as needed and from where it is available

[phsft-bot]

Build failed on ROOT-fedora32/noimt.
Running on root-fedora32-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

• [2021-05-27T07:49:34.319Z] math/unuran/unuran-1.8.0-root/src/methods/mvtdr_init.ch:886:17: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]

Failing tests:

• projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_simpleWriteRead
• projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_simpleRead
• projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

[oshadura]

LGTM! @mrodozov can you please confirm it fixes reported issue?

[mrodozov]

it does just built it

[oshadura]

@hahnjo thanks a lot for fix! (and thanks to @mrodozov for reporting and testing!)