[CMake] Don't set the PATH variable in any test environment
#21014
+24
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If things are set up correctly with CMake targets and using `gROOT->GetBinDir()` at runtime to find the ROOT executables corresponding to the current ROOT build, setting `PATH` should never be needed. This stress tests a bit more ROOTs capability of being independend of environment variables, and also makes the CMake code more consistent between platforms.
Test Results 22 files 22 suites 3d 12h 15m 33s ⏱️ For more details on these failures, see this check. Results for commit 810c4f8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If things are set up correctly with CMake targets and using
gROOT->GetBinDir()at runtime to find the ROOT executables corresponding to the current ROOT build, settingPATHshould never be needed.This stress tests a bit more ROOTs capability of being independend of environment variables, and also makes the CMake code more consistent between platforms.
This is the same as #21003, but for the other tests in ROOT that are not the tutorial tests.