[ntuple] deprecate small helpers in RFieldDescriptor #20370
+70
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query methods `IsCustomClass`, `IsCustomEnum`, and `IsStdAtomic` are rather arbitrary and should not have been added to the public interface. They only make sense in the internal context in which they are used. Removed for v6.42.
Test Results 21 files 21 suites 3d 15h 46m 50s ⏱️ Results for commit f73b4cb. ♻️ This comment has been updated with latest results. |
hahnjo
approved these changes
Nov 11, 2025
| std::function<void(const RFieldDescriptor &)> fnWalkFieldTree; | ||
| fnWalkFieldTree = [&desc, &streamerInfoMap, &fnWalkFieldTree](const RFieldDescriptor &fieldDesc) { | ||
| if (fieldDesc.IsCustomClass()) { | ||
| if (Internal::IsCustomClassFieldDesc(fieldDesc)) { |
Member
There was a problem hiding this comment.
Given this goes away, do we even need Internal::IsCustomClassFieldDesc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query methods
IsCustomClass,IsCustomEnum, andIsStdAtomicare rather arbitrary and should not have been added to the public interface. They only make sense in the internal context in which they are used.Removed for v6.42.