[core] Fold AutoloadLibraryMU into AutoloadLibraryGenerator #16969
Conversation
Test Results 18 files 18 suites 3d 19h 47m 57s ⏱️ Results for commit c0fd8cb. ♻️ This comment has been updated with latest results. |
Use AbsoluteSymbolsMaterializationUnit to define the symbols.
hahnjo
force-pushed
the
cling-autoload-absolute
branch
from
2c0bc2e to
c0fd8cb
Compare
|
As far as I could understand, Lang recommends this simplification, so marking as ready for review |
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Do we have any performance numbers? Is the absolute symbol approach similar in terms of computational cost?
| llvm::orc::SymbolMap loadedSymbols; | ||
| for (const auto &KV : found) { | ||
| // Try to load the library which should provide the symbol definition. | ||
| // TODO: Should this interface with the DynamicLibraryManager directly? |
There was a problem hiding this comment.
Yes, ideally that'd be a good idea...
I'm not sure I understand, this PR is just moving the code from the MU to the Generator. |
I think it answers my question. |
2 participants
Use
AbsoluteSymbolsMaterializationUnitto define the symbols.