Skip to content

[PyROOT] Update cppyy to a recent version #14507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 7 commits into from
Mar 19, 2024
Merged

[PyROOT] Update cppyy to a recent version #14507

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0175a52
Revert "[PyROOT] Forward compatibility of pretty printing with CPyCppyy"
guitargeek Mar 16, 2024
c6b238a
[PyROOT] Add cppyy synchronization script and update patches
guitargeek Mar 8, 2024
699a878
[PyROOT] Update to a patched version of current cppyy `master`
guitargeek Mar 8, 2024
763f036
[cppyy-backend] Minimal updates to use the most recent CPyCppyy
guitargeek Jan 31, 2024
98dc0c7
[PyROOT] Update reference counter reference value for Numba tests
guitargeek Mar 15, 2024
9275b03
[PyROOT] Adopt to no conversion from `char[]` to Python `str`
guitargeek Mar 15, 2024
9c4418a
[relnotes] Mention cppyy upgrade in release notes
guitargeek Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/pyroot/pythonizations/test/numbadeclare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def fn1(x):

self.assertTrue(hasattr(fn1, "__cpp_wrapper__"))
self.assertTrue(type(fn1.__cpp_wrapper__) == str)
self.assertEqual(sys.getrefcount(fn1.__cpp_wrapper__), 2)
self.assertEqual(sys.getrefcount(fn1.__cpp_wrapper__), 3)
Copy link
Member

@vepadulano vepadulano Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we even testing this? I believe it's not necessary and as your commit message rightly says, fragile. Let's just remove it

Copy link
Contributor Author

@guitargeek guitargeek Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I'm not familiar with the tests.

Right now things are quite stable with only this little change of the reference value, but if you agree that it can be removed I'm happy to do this as soon as the test fails somewhere again!


self.assertTrue(hasattr(fn1, "__py_wrapper__"))
self.assertTrue(type(fn1.__py_wrapper__) == str)
Expand Down