Remove gitinfo.txt in favor of RGitCommit.h
#13643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source dir is a git repo, `RGitCommit.h` remains authoritative and unchanged. If the source dir is not a git repo, RGitCommit.h can be generated without `git` thanks to the data in RVersion.hxx: - an even ROOT_PATCH_VERSION indicates that this is a tag. - an odd ROOT_PATCH_VERSION indicates that this is a development version. I.e. for all cases where a source tarball instead of a git repo, RGitCommit.h can be constructed during the build, and gitinfo.txt (which used to be generated during the build time, and needed to be generated / updated before `make distsrc` could be called) is not needed anymore. Drop GIT_TIMESTAMP - the doc of `TROOT::GetGitTimestamp()` always said "build time", not "commit time", i.e. this is actually a bug fix :-)' Mention this change and the prior removal of `build/version_number` in the release notes.
Axel-Naumann
requested review from
bellenot,
pcanal and
vepadulano
as code owners
|
Starting build on |
|
Starting build on |
Member
Author
|
Closed in favor of #13653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.