Make the dyld-based library search behavior default for non-modules. #10193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dyld-based system was developed in the context on C++ modules but it turned into a modules-agnostic feature. Instead of having to maintain more code, we should rely on it even for non-modules build of ROOT.
|
Starting build on |
Member
Author
|
@smuzaffar, could you check if this PR works with cmssw? |
Contributor
|
@vgvassilev , I have started the tests here cms-sw#165 |
Member
Author
|
@smuzaffar, is this compilation error that the bot reported relevant or it is some glitch? |
Contributor
|
@vgvassilev , this looks good. CMSSW PR tests worked fine. |
Member
Author
|
@smuzaffar thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dyld-based system was developed in the context on C++ modules but it turned into a modules-agnostic feature. Instead of having to maintain more code, we should rely on it even for non-modules build of ROOT.