209 convert member to support member #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $supportMember->setDateOfBirth($member->getDateOfBirth()); | ||
| $supportMember->setRegistrationTime(new DateTime()); // now seems more logically | ||
|
|
||
| // Should this become a new one, because i assume message is different, don't know where it is set |
There was a problem hiding this comment.
Goede vraag, steunleden betalen vaak andere contributie en ik weet niet zeker of we het bedrag kunnen aanpassen zonder opnieuw mandaat te vragen.
There was a problem hiding this comment.
Een mollie subscription heeft een methode om het bedrag te updaten. zie:
Maar ik weet niet of het zomaar mag
ikjelle
force-pushed
the
209-convert-member-to-support-member
branch
from
1118a04 to
4fbf647
Compare
Nowa-Ammerlaan
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Twee puntjes:
- Het is handig as we dit knopje ook in de lijst met leden toevoegen zodat je meerdere leden in bulk kan omzetten naar steunlid.
- We verliezen het originele lidnummer in dit process, het lijkt mij handig om deze ook op te slaan zodat wij onderscheid kunnen maken tussen steunleden die vroeger lid zijn geweest en steunleden die nooit lid zijn geweest.
Signed-off-by: Nowa Ammerlaan <[email protected]>
Gwildor
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: 209
Kopieer het lid naar steunlid en verwijder het lid uit de leden tabel.