Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move build tx out of execution bench #1390

Merged
merged 7 commits into from
Feb 22, 2024
Merged

ci: move build tx out of execution bench #1390

merged 7 commits into from
Feb 22, 2024

Conversation

popcnt1
Copy link
Collaborator

@popcnt1 popcnt1 commented Feb 21, 2024

Summary

  1. move build tx out of execution bench, result:

#1383 (comment)

  1. split write/query bench

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 11:30am

@popcnt1 popcnt1 marked this pull request as draft February 21, 2024 16:12
huge improvement(It's actually closer to the real server-side execution overhead) , the major cost is from tokio wake

```
RUST_LOG=error cargo bench --bench bench_tx_write
   Compiling rooch-benchmarks v0.1.0 (/Users/templex/rooch/bodhi/rooch/crates/rooch-benchmarks)
    Finished bench [optimized + debuginfo] target(s) in 12.05s
     Running benches/bench_tx_write.rs (/Users/templex/rooch/bodhi/rooch/target/release/deps/bench_tx_write-624c3ac78421ba7f)
execute_tx              time:   [388.70 µs 389.91 µs 391.12 µs]
                        change: [-97.069% -97.059% -97.049%] (p = 0.00 < 0.05)
                        Performance has improved.
```
@popcnt1 popcnt1 changed the title ci: split write/query benchmark ci: move build tx out of execution bench Feb 22, 2024
@popcnt1 popcnt1 marked this pull request as ready for review February 22, 2024 11:30
@popcnt1 popcnt1 merged commit 59d7ce7 into main Feb 22, 2024
2 of 3 checks passed
@popcnt1 popcnt1 deleted the perf.bench branch February 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants