dannyhw/fix/nwui template issues #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update more dependencies fix: keep reanimted v3 for nativewind fix: keep reanimted v3 for nativewind fix fix: ensure we install 53 until we are ready to support 54 fix: tests should run fix: extra changeset fix: use reanimated 4 always run tests with node fix: ensure we install 53 until we are ready to support 54 chore(release): version packages fix: generating projects with yarn chore(release): version packages fix: tests fix fix: snapshots fix: extra comma breaking chore(release): version packages
fix: resolve TypeScript error in authentication select options fix: scripts
dannyhw
commented
Sep 19, 2025
| screenOptions={{ | ||
| tabBarActiveTintColor: 'black', | ||
| }}> | ||
| <Tabs> |
There was a problem hiding this comment.
this was causing the icon to be barely visible in dark mode
dannyhw
commented
Sep 19, 2025
| onPress={() => bottomSheetModalRef.current?.present()} | ||
| /> | ||
| <Sheet ref={bottomSheetModalRef} snapPoints={[200]}> | ||
| <Sheet ref={bottomSheetModalRef} snapPoints={[200]} enableDynamicSizing={false}> |
There was a problem hiding this comment.
fixes bottom sheet not opening
dannyhw
force-pushed
the
dannyhw/fix/nwui-template-issues
branch
from
01bc0c1 to
ede6be8
Compare
fix: tsc error fix: changeset
dannyhw
force-pushed
the
dannyhw/fix/nwui-template-issues
branch
from
ede6be8 to
11b6e68
Compare
|
@dannyhw can you go through this PR and let me know what if anything needs to be updated given my recent updates to NWUI? If you think it's easier, we can close this for now and open a new PR for any desired changes. |
|
@danstepanov I think enough changes have probably been made that its easier to close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):