Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local ronin package #15

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Use local ronin package #15

merged 4 commits into from
Jan 7, 2025

Conversation

colodenn
Copy link
Member

@colodenn colodenn commented Jan 7, 2025

To ensure the getBatchProxy function operates correctly, it was necessary for the global and local versions of ronin to be synchronized. To address the issue of version mismatch, we have updated the implementation to dynamically import ronin from the project's local node_modules directory, rather than relying on the globally installed version.

@colodenn colodenn added the bug Something isn't working label Jan 7, 2025
@colodenn colodenn requested a review from leo January 7, 2025 11:32
@colodenn colodenn self-assigned this Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/protocol.ts 100.00% <100.00%> (ø)

Copy link

github-actions bot commented Jan 7, 2025

Released an experimental package:

bun add @ronin/cli@corny-ron-1071-experimental-43

This package will be removed after the pull request has been merged.

@colodenn colodenn marked this pull request as ready for review January 7, 2025 11:36
src/utils/protocol.ts Outdated Show resolved Hide resolved
@colodenn colodenn merged commit 3035606 into main Jan 7, 2025
3 checks passed
@colodenn colodenn deleted the corny/ron-1071 branch January 7, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants