Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make React v19 working. #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make React v19 working. #131

wants to merge 1 commit into from

Conversation

vince1995
Copy link

This package currently doesn't work with React 19.

There are slight changes to do that it works again:

  • Update dependencies to React 19.
  • react/jsx-runtime has also to be an external in the vite.config.ts file.

rommguy
rommguy approved these changes Feb 22, 2025
View reviewed changes
Copy link
Owner

@rommguy rommguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@rommguy
Copy link
Owner

rommguy commented Feb 22, 2025

I see the tests can't run - can you please merge from main?
I pushed an upgrade to the github actions versions.
Also - I understand that after this merge react-custom-scroll won't be usable with React 18?
Is it possible to support both versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rommguy rommguy rommguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vince1995 @rommguy