Skip to content

[ROMM-2877] Drop index on rom file content #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gantoine merged 1 commit into from
Jan 10, 2026
+2 −28
Merged

[ROMM-2877] Drop index on rom file content #2878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions backend/alembic/versions/0057_multi_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
from alembic import op
from sqlalchemy import text

from utils.database import is_mariadb, is_mysql

# revision identifiers, used by Alembic.
revision = "0057_multi_notes"
down_revision = "0056_gamelist_xml"
Expand Down Expand Up @@ -57,17 +55,6 @@ def upgrade() -> None:
op.create_index("idx_rom_notes_rom_user", "rom_notes", ["rom_id", "user_id"])
op.create_index("idx_rom_notes_title", "rom_notes", ["title"])

# Get connection for manual index creation
connection = op.get_bind()

# For MariaDB compatibility, we limit the content index length
if is_mysql(connection) or is_mariadb(connection):
connection.execute(
text("CREATE INDEX idx_rom_notes_content ON rom_notes (content(100))")
)
else:
op.create_index("idx_rom_notes_content", "rom_notes", ["content"])

# Add default values to old note columns to prevent insertion errors
# This allows new rom_user records to be created without specifying note fields
op.alter_column(
Expand All @@ -87,7 +74,7 @@ def upgrade() -> None:

# Migrate existing notes from rom_user to rom_notes table
# Both note_raw_markdown and note_is_public columns exist from previous migrations

connection = op.get_bind()
result = connection.execute(
text(
"""
Expand Down Expand Up @@ -124,8 +111,6 @@ def upgrade() -> None:
def downgrade() -> None:
"""Drop the rom_notes table and restore note columns to rom_user."""

connection = op.get_bind()

# Add back the old columns to rom_user
op.add_column(
"rom_user",
Expand All @@ -139,7 +124,7 @@ def downgrade() -> None:
)

# Migrate notes back to rom_user (take first note per user/rom)

connection = op.get_bind()
result = connection.execute(
text(
"""
Expand Down Expand Up @@ -168,17 +153,6 @@ def downgrade() -> None:
},
)

# Drop indexes and table
if is_mysql(connection) or is_mariadb(connection):
# The content index was created with a specific length using raw SQL for MySQL/MariaDB,
# so we drop it with raw SQL as well.
connection.execute(
text("DROP INDEX IF EXISTS idx_rom_notes_content ON rom_notes")
)
else:
# For other databases, the content index was created with op.create_index.
op.drop_index("idx_rom_notes_content", table_name="rom_notes")

# These indexes were created with op.create_index for all dialects.
op.drop_index("idx_rom_notes_title", table_name="rom_notes")
op.drop_index("idx_rom_notes_rom_user", table_name="rom_notes")
Expand Down
Loading