ci: run Trunk linters on Node 24 - #148
Merged
Merged
Conversation
Bump the Trunk node runtime from 18.20.5 to 24.21.0. markdownlint-cli 0.44.0 reads fs.R_OK, which Node 24 deprecates. The warning lands in the JSON output and Trunk fails to parse it, so bump markdownlint to 0.45.0. That release adds MD059 (descriptive link text), so reword the two "[here]" links in the contributing guides. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noderuntime from 18.20.5 to 24.21.0.markdownlintfrom 0.44.0 to 0.45.0. On Node 24, 0.44.0 prints afs.R_OKdeprecation warning into its JSON output, which Trunk can't parse, so every markdownlint run fails.[here]links inCONTRIBUTING.mdanddocs/developers/contributing.md.Test plan
trunk check --all --no-fix --cipasses locally on Node 24 (fails on this runtime with markdownlint 0.44.0)Companion to #147, which moves the GitHub Actions themselves to Node 24.
🤖 Generated with Claude Code