Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

640-refactor: Replace outdated header menu footer icon #724

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

640-refactor: Replace outdated header menu footer icon #724

wants to merge 13 commits into from
+336 −215

Conversation

pestler
Copy link
Collaborator

@pestler pestler commented Jan 10, 2025 •
edited
Loading

What type of PR is this? (select all that apply)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🚧 Breaking Change
  • 🧑‍💻 Code Refactor
  • 📝 Documentation Update

Description

Related Tickets & Documents

Screenshots, Recordings

Please replace this line with any relevant images for UI changes.

Added/updated tests?

  • 👌 Yes
  • [] 🙅‍♂️ No, because they aren't needed
  • [] 🙋‍♂️ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@pestler pestler self-assigned this Jan 10, 2025
@pestler pestler marked this pull request as draft January 10, 2025 10:30
@github-actions github-actions bot changed the title Refactor/640 replace outdated header menu footer icon 640-refactor: Replace outdated header menu footer icon Jan 10, 2025
@pestler pestler added good first issue Good for newcomers refactor and removed preview labels Jan 10, 2025
SpaNb4
SpaNb4 reviewed Jan 13, 2025
View reviewed changes
src/shared/assets/icons/react-256.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/react-256 copy.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/javascript-256.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/amazon-web-services-logo-wine-256.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/footer/node-js-256.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/node-js-black-256.svg Outdated Show resolved Hide resolved
src/shared/assets/icons/footer/html5-256.svg Outdated Show resolved Hide resolved
dev-data/courses.data.ts Outdated Show resolved Hide resolved
src/shared/assets/icons/footer/react-256.svg Outdated Show resolved Hide resolved
@ansivgit ansivgit added the draft PR draft label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaNb4 SpaNb4 SpaNb4 approved these changes

@andron13 andron13 Awaiting requested review from andron13 andron13 is a code owner

@dzmitry-varabei dzmitry-varabei Awaiting requested review from dzmitry-varabei dzmitry-varabei is a code owner

@Quiddlee Quiddlee Awaiting requested review from Quiddlee Quiddlee is a code owner

@ansivgit ansivgit Awaiting requested review from ansivgit ansivgit is a code owner

@natanchik natanchik Awaiting requested review from natanchik natanchik is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@pestler pestler

Labels
draft PR draft good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace outdated header-menu, footer icon
3 participants
@pestler @SpaNb4 @ansivgit