wip: support plugin-legacy

rolldown · Jan 6, 2025 · 9650262 · 9650262
1 parent 5a3ed8b
commit 9650262
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 19 deletions.
diff --git a/packages/plugin-legacy/package.json b/packages/plugin-legacy/package.json
@@ -42,6 +42,8 @@
   "funding": "https://github.com/vitejs/vite?sponsor=1",
   "dependencies": {
     "@babel/core": "^7.26.0",
+    "@babel/plugin-transform-dynamic-import": "^7.25.9",
+    "@babel/plugin-transform-modules-systemjs": "^7.25.9",
     "@babel/preset-env": "^7.26.0",
     "browserslist": "^4.24.3",
     "browserslist-to-esbuild": "^2.1.1",

diff --git a/packages/plugin-legacy/src/index.ts b/packages/plugin-legacy/src/index.ts
@@ -17,6 +17,7 @@ import type {
   OutputBundle,
   OutputChunk,
   OutputOptions,
+  PluginContext,
   PreRenderedChunk,
   RenderedChunk,
 } from 'rollup'
@@ -174,6 +175,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
   const legacyPolyfills = new Set<string>()
   // When discovering polyfills in `renderChunk`, the hook may be non-deterministic, so we group the
   // modern and legacy polyfills in a sorted chunks map for each rendered outputs before merging them.
+  // TODO: options object is not identical, so Map won't work
   const outputToChunkFileNameToPolyfills = new WeakMap<
     NormalizedOutputOptions,
     Map<string, { modern: Set<string>; legacy: Set<string> }> | null
@@ -282,13 +284,14 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
         return
       }
 
-      const chunkFileNameToPolyfills =
-        outputToChunkFileNameToPolyfills.get(opts)
-      if (chunkFileNameToPolyfills == null) {
-        throw new Error(
-          'Internal @vitejs/plugin-legacy error: discovered polyfills should exist',
-        )
-      }
+      // const chunkFileNameToPolyfills =
+      //   outputToChunkFileNameToPolyfills.get(opts)
+      // if (chunkFileNameToPolyfills == null) {
+      //   throw new Error(
+      //     'Internal @vitejs/plugin-legacy error: discovered polyfills should exist',
+      //   )
+      // }
+      const chunkFileNameToPolyfills = new Map()
 
       if (!isLegacyBundle(bundle, opts)) {
         // Merge discovered modern polyfills to `modernPolyfills`
@@ -305,6 +308,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
           )
         }
         await buildPolyfillChunk(
+          this,
           config.mode,
           modernPolyfills,
           bundle,
@@ -347,6 +351,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
         }
 
         await buildPolyfillChunk(
+          this,
           config.mode,
           legacyPolyfills,
           bundle,
@@ -434,7 +439,9 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
       ): OutputOptions => {
         return {
           ...options,
-          format: 'system',
+          // TODO
+          format: 'esm',
+          // format: 'system',
           entryFileNames: getLegacyOutputFileName(options.entryFileNames),
           chunkFileNames: getLegacyOutputFileName(options.chunkFileNames),
         }
@@ -455,7 +462,8 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
       }
     },
 
-    async renderChunk(raw, chunk, opts, { chunks }) {
+    // TODO: meta.chunks not supported
+    async renderChunk(raw, chunk, opts, { chunks } = { chunks: {} }) {
       if (config.build.ssr) {
         return null
       }
@@ -472,11 +480,15 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
         }
         outputToChunkFileNameToPolyfills.set(opts, chunkFileNameToPolyfills)
       }
-      const polyfillsDiscovered = chunkFileNameToPolyfills.get(chunk.fileName)
-      if (polyfillsDiscovered == null) {
-        throw new Error(
-          `Internal @vitejs/plugin-legacy error: discovered polyfills for ${chunk.fileName} should exist`,
-        )
+      // const polyfillsDiscovered = chunkFileNameToPolyfills.get(chunk.fileName)
+      // if (polyfillsDiscovered == null) {
+      //   throw new Error(
+      //     `Internal @vitejs/plugin-legacy error: discovered polyfills for ${chunk.fileName} should exist`,
+      //   )
+      // }
+      const polyfillsDiscovered = {
+        modern: new Set(),
+        legacy: new Set(),
       }
 
       if (!isLegacyChunk(chunk, opts)) {
@@ -545,6 +557,12 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
       // transform the legacy chunk with @babel/preset-env
       const sourceMaps = !!config.build.sourcemap
       const babel = await loadBabel()
+      const systemJsPlugins = [
+        // @ts-ignore
+        (await import('@babel/plugin-transform-dynamic-import')).default,
+        // @ts-ignore
+        (await import('@babel/plugin-transform-modules-systemjs')).default,
+      ]
       const result = babel.transform(raw, {
         babelrc: false,
         configFile: false,
@@ -557,6 +575,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
           [
             () => ({
               plugins: [
+                ...systemJsPlugins,
                 recordAndRemovePolyfillBabelPlugin(polyfillsDiscovered.legacy),
                 replaceLegacyEnvBabelPlugin(),
                 wrapIIFEBabelPlugin(),
@@ -718,7 +737,8 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
         // avoid emitting duplicate assets
         for (const name in bundle) {
           if (bundle[name].type === 'asset' && !/.+\.map$/.test(name)) {
-            delete bundle[name]
+            // TODO: don't delete polyfil chunk emitted as asset
+            // delete bundle[name]
           }
         }
       }
@@ -781,6 +801,7 @@ function createBabelPresetEnvOptions(
 }
 
 async function buildPolyfillChunk(
+  ctx: PluginContext,
   mode: string,
   imports: Set<string>,
   bundle: OutputBundle,
@@ -846,16 +867,23 @@ async function buildPolyfillChunk(
     }
   }
 
+  // TODO: adding a whole new chunk to `bundle` is not supported by rolldown.
+  // can we use `emitFile(asset)` instead?
+  ctx.emitFile({
+    type: 'asset',
+    fileName: polyfillChunk.fileName,
+    source: polyfillChunk.code,
+  })
   // add the chunk to the bundle
-  bundle[polyfillChunk.fileName] = polyfillChunk
+  // bundle[polyfillChunk.fileName] = polyfillChunk
   if (polyfillChunk.sourcemapFileName) {
     const polyfillChunkMapAsset = _polyfillChunk.output.find(
       (chunk) =>
         chunk.type === 'asset' &&
         chunk.fileName === polyfillChunk.sourcemapFileName,
     ) as OutputAsset | undefined
     if (polyfillChunkMapAsset) {
-      bundle[polyfillChunk.sourcemapFileName] = polyfillChunkMapAsset
+      // bundle[polyfillChunk.sourcemapFileName] = polyfillChunkMapAsset
     }
   }
 }
@@ -907,14 +935,15 @@ function prependModenChunkLegacyGuardPlugin(): Plugin {
 }
 
 function isLegacyChunk(chunk: RenderedChunk, options: NormalizedOutputOptions) {
-  return options.format === 'system' && chunk.fileName.includes('-legacy')
+  return chunk.fileName.includes('-legacy')
+  // return options.format === 'system' && chunk.fileName.includes('-legacy')
 }
 
 function isLegacyBundle(
   bundle: OutputBundle,
   options: NormalizedOutputOptions,
 ) {
-  if (options.format === 'system') {
+  if (true || options.format === 'system') {
     const entryChunk = Object.values(bundle).find(
       (output) => output.type === 'chunk' && output.isEntry,
     )

diff --git a/playground/legacy/vite.config.js b/playground/legacy/vite.config.js
@@ -13,6 +13,7 @@ export default defineConfig({
   ],
 
   build: {
+    minify: false,
     cssCodeSplit: false,
     manifest: true,
     sourcemap: true,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml