-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a Web Page for predicting the stock price and also implemented concept of ensemble learning closes #132 #151
Conversation
…d concept of ensemble learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time
I have checked and I have done all the tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balbirs22 Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
If needed, please check out merged PRs for reference.
Thanks & regards
How I have done please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
please sync your repo with the latest changes |
@balbirs22 you will also need to mention the steps in contributing.md |
@balbirs22 please ensure that all other notebooks in the main repo that you are not working is present in your commit |
@jvedsaqib I have ensured that as I only added or modified notebooks and not deleted any thing |
🎉🎉 Thank you for your contribution! Your PR #151 has been merged! 🎉🎉 |
Issue Reference:
Closes #132
Description of changes: Closes #132