SHS Dashboard Frontend Chart - Source of visit for each blog page #71 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohithaug
requested changes
Feb 29, 2024
suryavanshi18
commented
Mar 1, 2024
vishaln15
requested changes
Mar 1, 2024
There was a problem hiding this comment.
I believe @rohithaug is better qualified to review the charts part of this file. However, the first part of getMetrics() needs to fixed.
| @@ -0,0 +1,54 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
| import Chart from 'chart.js/auto'; | |||
| import {getMetrics} from '../../../app/services/analytics.service.js'; | |||
There was a problem hiding this comment.
@suryavanshi18 The getMetrics() is a service written in the backend. Ideally, we would need to request for the data from the backend. In this case, we need to write a fetch() call to get the required data, else this wouldn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on #7 and #72
Not sure on the api url at line 10 which is used to fetch the api data