Alternative archs build #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roerohan
requested changes
Mar 20, 2023
Comment on lines
+23
to
+25
| CGO_ENABLED=0 GOOS=linux GOARCH=386 go build -ldflags "-s -w" -o ./bin/wait-for-it.linux-386.exe | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-linux-amd64.exe | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w" -o ./bin/wait-for-it-linux-arm64.exe |
Comment on lines
+73
to
+74
| CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-darwin-amd64.exe | ||
| CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-darwin-arm64.exe |
Comment on lines
+32
to
+34
| ./bin/wait-for-it.linux-i386 | ||
| ./bin/wait-for-it.linux-amd64 | ||
| ./bin/wait-for-it.linux-arm64 |
There was a problem hiding this comment.
I think we should also copy the wait-for-it.linux-arm64 binary to wait-for-it, since I've seen a couple of people use it in their docker containers directly from the releases on this repo. It would break for them if we don't have a binary called wait-for-it.
| @@ -130,6 +143,6 @@ jobs: | |||
| - name: Upload Release Asset | |||
| id: upload-release-asset | |||
| run: | | |||
| hub release edit -a ./bin/wait-for-it -a ./bin/wait-for-it_mac -a ./bin/wait-for-it_win64.exe -m "" ${{ env.VERSION }} | |||
| hub release edit -a ./bin/wait-for-it.linux-i386 -a ./bin/wait-for-it.linux-amd64 -a ./bin/wait-for-it.linux-arm64 -a ./bin/wait-for-it.windows-i386.exe -a ./bin/wait-for-it.windows-amd64.exe -a ./bin/wait-for-it.windows-arm64.exe -a ./bin/wait-for-it.darwin-amd64 -a ./bin/wait-for-it.darwin-arm64 -m "" ${{ env.VERSION }} | |||
There was a problem hiding this comment.
Add the wait-for-it binary here as well.
|
Hi @rubnogueira , thanks for contributing 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the binaries to alternative systems