fix: keep Activity commit details after browser Back - #7
Open
rodboev wants to merge 2 commits into
Open
Conversation
rodboev
force-pushed
the
pr/activity-commit-pane-back
branch
from
September 4, 2026 22:35
5fba33f to
f6aab40
Compare
wesm
pushed a commit
to kenn-io/forge
that referenced
this pull request
Sep 5, 2026
Default-branch commit details selected from Activity now survive leaving the page and returning with browser Back. The Activity URL uses the existing selection slot for commits, pull requests, and issues, keeping those detail panes mutually exclusive while preserving filters and existing phone behavior. This brings [rodboev#7](rodboev#7) into forge proper with the contributor commits preserved. Refs #452 Co-authored-by: Marius van Niekerk <mariusvniekerk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A default-branch commit opened from the Activity feed now survives leaving Activity and pressing browser Back, the same way a selected pull request or issue already does. The restored header keeps the commit identity with its branch and short SHA.
The commit identity now uses the existing Activity URL state with a
commit:<sha>value, repo identity, and branch. The view keeps its standalone behavior while the app shell owns the controlled selection, so oneselectedslot keeps commit, pull request, and issue details mutually exclusive. Activity filters, the route memory from #810, existing pull request and issue restoration, and the phone surface stay unchanged.The PR-merge-modal Escape symptom remains a separate follow-up because it has a different modal ownership boundary. No server, schema, or generated API changes are included.
Refs kenn-io#452