Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate OG image URL during build #238

Closed
wants to merge 804 commits into from

Conversation

andreilgeorgescu
Copy link
Collaborator

@andreilgeorgescu andreilgeorgescu commented Jan 21, 2025

Fixes #236

andreilgeorgescu and others added 13 commits December 11, 2024 17:09
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 4.15.11 to 4.16.18.
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/[email protected]/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/[email protected]/packages/astro)

---
updated-dependencies:
- dependency-name: astro
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove remaining Black Friday content
Fixes #201

* Update astro.config.mjs

Co-authored-by: Andrei Liviu Georgescu <[email protected]>

* Update astro.config.mjs

Co-authored-by: Andrei Liviu Georgescu <[email protected]>

* Update Black Friday folder

---------

Co-authored-by: Andrei Liviu Georgescu <[email protected]>
* Format

* Format

* Format more

---------

Co-authored-by: wkenned1 <[email protected]>
* Add articles placeholder

* Make description field optional in series schema

* Add articles series content collections

* Add ArticleSeriesTop component to display related articles

* Wrap previous articles section in a WarningAdmonition component for improved visibility

* Hide `ArticleSeriesTop` on first article of series

* Highlight current article

* Remove "You are here" label from ArticleSeries components for cleaner UI

* Add underline to article titles in ArticleSeries components for improved emphasis

* Combine top and bottom ArticleSeries component

* Replace underline with italic styling for article titles in ArticleSeries component

* Use card component

* Add label and open state to ArticleSeries component for improved navigation

* Add underline styling to the label in ArticleSeries component for improved emphasis

* Override prose css

* Remove uneccessary div

* Move `AritcleLayouts` to header and footer

* Remove prose utility classes from `ArticleSeries`

* Update MyYouTube component to center align the video with mx-auto class

* Update ArticleSeries label for clarity in ArticleLayout

* Add padding to ArticleSeries section and clean up class attributes

* Refactor ArticleSeries section to use dynamic background classes and improve text styling

* Adjust padding and margin for improved layout in ArticleSeries component

* Refactor ArticleSeries component to simplify class attributes and enhance layout

* Update color variables and enhance card shadow styling in base.css

* Wrap ArticleSeries component in a div for improved spacing in ArticleLayout

* Have consistent gradient for both top and bottom article series component

* Add label to article series component for improved accessibility

* Enhance ArticleSeries component layout with flexbox for better alignment

* Remove arrow

* Update label in ArticleSeries component for clarity

* Add NewsletterSection component for user subscription

* Adjust padding in NewsletterSection component for improved spacing

* Add NewsletterSection to ArticleLayout for user subscription

* Fix article series component

* Correct import statement for ArticleSeries component

* Rename ArticleSeries component to ArticleSeriesHelper and update import references

* Refactor `ArticleSeriesHelper.jsx` to be compatible with React

* Update arrow and move it to the left

* Update newsletter form text

---------

Co-authored-by: wkenned1 <[email protected]>
* Install `astro-pagefind` integration

* Reorder `pagefind` integration to be the last plugin in the configuration

* Add search component to header

* Add modal search component

* Refactor modal component

* Implement keyboard shortcuts for modal: open with Ctrl+K/Cmd+K

* Update search button label to include keyboard shortcut (Ctrl+K)

* Fix type errors

* Add mock of how button should look

* Add support for picking which pages to index

* Add courses to search index

* Add articles to search index

* Add sub results to search

* Test: add images to search

* Add ability to select search image

* Add course hero image as search image

* Add author filter to article layout for improved search indexing

* Change `author` filter to plural

* Update article and course layouts to include type in search filter

* Update search component to hide empty filters in modal

* Add articleTags to search filter

* Add `date` search metadata to articles

* Refactor article layout to separate search filter data attributes

* Revamp date formatting

* Refactor article and course layouts to use divs for search filters and metadata

* Update modal width for improved responsiveness in search component

* Add category filters to article and course layouts for improved search functionality

* Add search filter Tag ID to tags

* Update search tags to be capitalized

* Reverse logic to fix courses search filter bug

* Capitalize category names in article layout to fix bug

* Refactor header and search components for improved layout and responsiveness

* Update filter data attributes to use plural 'Categories' for articles and courses

* Remove redundant logic for closing modal

* Rename remaining `Category` search filters to plural

* Update modal panel to have mobile responsiveness

* Make modal maximum to avoid overlapping bugs

* Style search

Co-authored-by: wkenned1 <[email protected]>

* Cleanup styling

Co-authored-by: wkenned1 <[email protected]>

* Update tag colors in MySearch component for consistency across themes

* USe brighter search color and increase popup width

---------

Co-authored-by: wkenned1 <[email protected]>
Co-authored-by: wkenned1 <[email protected]>
* scala at light speed link bug

* course layout and display fixes

* holiday page + flags

* Remove active references

* Remove more uses of active

---------

Co-authored-by: wkenned1 <[email protected]>
@andreilgeorgescu andreilgeorgescu self-assigned this Jan 21, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying rockthejvm-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc3a66a
Status: ✅  Deploy successful!
Preview URL: https://a771152d.rockthejvm-site.pages.dev
Branch Preview URL: https://andreilgeorgescu-issue236.rockthejvm-site.pages.dev

View logs

@andreilgeorgescu
Copy link
Collaborator Author

andreilgeorgescu commented Jan 25, 2025

Investigation of why LinkedIn doesn't display the og image:

  • og:image:secure_url
  • Extension
  • Query parameters
  • CORS Headers
  • Image itself
  • Load time
  • Bot blocking
  • Domain <-- The issue

@daniel-ciocirlan
Copy link
Collaborator

@andreilgeorgescu about the default OG image, I'd say one of these two:

  • With logos
  • Simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate OG image URL during build
5 participants