Skip to content

Conversation

@kanecko
Copy link
Contributor

@kanecko kanecko commented Nov 23, 2025

To ease and accelerate the PR submission, please use the template below to provide all required information.
Please see our "Contributing to Rockstor documentation" in our Rockstor's documentation

Fixes #571

This pull request's proposal

Removes images, uses bullet points

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Removed redundant installation steps and images for Immich Rock-on setup. Updated instructions for clarity and conciseness.
Removed line break for better readability in instructions.
@phillxnet
Copy link
Member

phillxnet commented Nov 24, 2025

@kanecko Could you please squash these development commits into a single one and re-present in a new PR. We prefer to receive non draft pull requests, at least initially, as a single commit detailing the aim. When you then create a pull request with that single commit its text can be the pull request message. But some tailoring is required to fit our template.

Also from a quick look, this pull request looks to have deleted all the images. Maybe you missed git add on the newer images that I'm assuming you wanted to present here.

Hope that helps, and great to have a follow-up so soon on this doc. Cheers.

Plus, it seems like we are for once getting a clean/green check on our git Actions now.

@kanecko
Copy link
Contributor Author

kanecko commented Nov 24, 2025

I have deleted all but one image. I have adapted my assumption of the target audience,and decided against babying the user. I will squash the commits when I find the time. Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Immich writeup

2 participants