-
Notifications
You must be signed in to change notification settings - Fork 97
Observability Starter Kit #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This JSON file defines an observability stack including OpenTelemetry, VictoriaMetrics, and Grafana, detailing their configurations and links.
|
Since the setup for this rock-on is very involved, I wonder, if I should first create a write-up for it? And afterwards you can review both the write-up as well as this rock-on together? Within the write-up, I would also create a starter Grafana dashboard JSON file for our Rockstor users. The dashboard would also be subject to review and I would love to publish it on Grafana Dashboards once it is good enough. Would that make sense? Otherwise, here is the a try at explaining what needs to be done. Pre-install steps:
Install rock-on. Post-install steps:
|
|
@kanecko Nice. Another quick note: we need make no mention of netdata in the description I think. This will also help to keep it to-the-point. |
|
Duly noted. I will delete netdata from the description. I thought that I read somewhere that we are supposed to give a comparison to rock-ons that solve the same kind of problem. |
|
@kanecko Re
Likely the guide/template that pops up as a rockon-registry PR template. Intended to given context for the proposed pull request. [EDIT]
|
|
@kanecko Re:
This is touching on what has been bothering us re required extensions to the Rock-on backend. Look to my forgejo-runner rock-on for one approach (work-around wise). We for now have to give users the run-around. But in an issue from @Hooverdan96 there is a neat suggestion regarding replacement variables within Rock-on definitions. Akin to bash variables. Take a look at: This is the issue I think: [Rockon]: Feature Request - add global variables to reduce duplicate UI entries #2935 [EDIT]: @Hooverdan96 quote form above: "A few Variables could be defined by default, e.g. the host ip/name - I assume those could be pulled directly from what already exists." We could then have for example some 'special' variables such as
This is covered in a recent discussion of ours here: rockstor/rockstor-core#3029 (comment) |
|
I will replace "--user" with env vars for USER_UID and USER_GID. I think using your workaround will solve this issue. |
I think having a write-up for this would be really great! Not sure you need to create it first, but I think once the above discussions are ironed out, you could then create the write-up for the documentation in the rockstor-doc repo. And, as you suggested, finally link to the documentation in the Rockon description (and there are a couple of Rockons that do the same) |
|
I have updated the JSON and my 2nd post (installation guide). After some research and testing, I've come to the realization that both OTel and Grafana official images have baked-in UID/GIDs. |
Removed Docker socket volume mount from options.
|
@phillxnet, @kanecko would it be better to leave the openTelemetry website as the link in the Rockon itself as it's the "underpinning" of this Rockon, and put the (eventual) link to the documentation on the Rockstor website into the Rockon description instead? I could try to argue either way, since this one is an assembly of different technologies, not just a multi-container Rockon where one component "dominates" the whole thing ... |
|
@kanecko & @Hooverdan96 Re:
Yes, we have recent precedent for this that I would like to propose as a standard/norm going forward: See: Bareos Backup Server: https://github.com/rockstor/rockon-registry/blob/master/bareos-backup-server.json I.e. we have a set link text target _blank of Rock-on guide in Description, ideally in a prominent position: e.g. end of line. Moving to such an arrangement can later enable our rockon-validator to re-write/move this to an element of its own once we have one. If that is the way we want to go when the time comes. |
Agreed, what do you suggest should be the Rockon title link? Like what @kanecko originally proposed |
|
@Hooverdan96 & @kanecko Re:
I think the opentelemetry.io link works - it is after all how all this is tied together. This Rock-on is shaping up to be a kind to sand-pit for trying out what could end-up being our Dashboard replacement - only not reliant on docker of course. |
|
I've added opentelemetry.io and the rock-on guide link with the would-be URL. |
|
Also see some comments I left for accompanying documentation in this PR. Install test: Links in description work as expected:
see comment in rockstor-doc PR about harmonizing share name instructions and example here ...
After first login prompted to change password: Creating Data Source (see comments over in Rockstor documentation PR)
Following the tutorial on adding a new metric:
How would I investigate the network issue on my install to ensure that this is just a one-off? Other than that I really like it!!! Especially in conjunction with the documentation |
|
@kanecko Apologies for the now required rebase and ideally a squash of all your commits on this pull request. We are, bit by bit, normalising our Rock-on format and this has now been done on the root.json. Plus, ideally, the initial presentation pre-review, should have only a single commit. |
|
@kanecko Re:
Keep an eye on the following pending final testing pull request earmarked for our first 5.5.X testing phase rpm: A proposal that includes a special gid value of -2 that instigates the substitution of the system's docker gid during Rock-on install. Otherwise it is a copy of our existing uid but for groups. |










Fixes #483 .
General information on project
This pull request proposes to add a new rock-on for the following project:
Information on docker image
Checklist
root.jsonin alphabetical order (for new rock-on only)"description"object lists and links to the docker image used"description"object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"object links to project's main website